Re: [PATCH] Input: goodix - Fix missing IRQF_ONESHOT as only threaded handler

[Krzysztof Kozlowski]

On Fri, 16 Apr 2021 at 05:18, <zhuguangqing83@xxxxxxxxx> wrote:
>
> From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
>
> Coccinelle noticed:
> drivers/input/touchscreen/goodix.c:497:8-33: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
> ---
>  drivers/input/touchscreen/goodix.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)


Did you test it? There are several patches like this all over the tree
so it looks like "let's fix everything from Coccinelle" because you
ignored at least in some of the cases that the handler is not the
default primary one. I am not saying that the change is bad, but
rather it looks automated and needs more consideration.

Best regards,
Krzysztof
Best regards,
Krzysztof