Re: [Linux-stm32] [PATCH 04/13] dt-bindings: mfd: stm32-timers: remove #address/size cells from required properties

From: Fabrice Gasnier
Date: Fri Apr 16 2021 - 11:53:21 EST


On 4/15/21 12:10 PM, Alexandre Torgue wrote:
> address-cells and size-cells can't be declared as "required" properties
> as they are not needed if subnodes don't have a "reg" entry.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> index 0f16c8864a87..dace35362a7a 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml

Hi Alexandre,

Not sure if this matters: patches 3 and 4 could be swapped in the
series. Apart from that:

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>

Thanks,
Fabrice
> @@ -119,8 +119,6 @@ patternProperties:
> - compatible
>
> required:
> - - "#address-cells"
> - - "#size-cells"
> - compatible
> - reg
> - clocks
>