Re: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer

From: Andy Shevchenko
Date: Fri Apr 16 2021 - 13:36:20 EST


On Thu, Apr 15, 2021 at 05:37:54PM +0300, Andy Shevchenko wrote:
> Strictly speaking the comparison between guid_t and raw buffer
> is not correct. Return to plain memcmp() since the data structures
> haven't changed to use uuid_t / guid_t the current state of affairs
> is inconsistent. Either it should be changed altogether or left
> as is.

Dan, please review this one as well. I think here you may agree with me.

--
With Best Regards,
Andy Shevchenko