Re: [PATCH] checkpatch: Improve ALLOC_ARRAY_ARGS test

[Christophe JAILLET]

Le 16/04/2021 à 19:03, Joe Perches a écrit :
> On Fri, 2021-04-16 at 18:51 +0200, Christophe JAILLET wrote:
> > Le 16/04/2021 à 18:11, Joe Perches a écrit :
> > > On Fri, 2021-04-16 at 17:58 +0200, Christophe JAILLET wrote:
> > > > The devm_ variant of 'kcalloc()' and 'kmalloc_array()' are not tested
> > > > Add the corresponding check.
> > > []
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > []
> > > > @@ -7006,9 +7006,9 @@ sub process {
> > > >    		}
> > > >    
> > > >
> > > >
> > > >    # check for alloc argument mismatch
> > > > -		if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
> > > > +		if ($line =~ /\b(devm_|)(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
> > >
> > > Perhaps nicer using
> > I'll send a V2.
> >
> > Thx for the feedback.
> >
> > CJ
> >
> > > 		if ($line =~ /\b((?:devm_)?(?:kcalloc|kmalloc_array))\s*\*\s*sizeof\b/) {
>
> The \* above should be \(.

Yes I've seen it when I tested the updated test case.

> I can't type and apparently I don't proofread either.
> I offer the excuse that the * and ( are adjacent on my keyboard...

Well, you should try with a French keyboard :)
Anyway, thanks for taking time for the update.

CJ

> cheers, Joe