RE: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat

From: David Laight
Date: Sat Apr 17 2021 - 09:19:10 EST


From: Mark Rutland
> Sent: 16 April 2021 14:35
..
> @@ -51,13 +48,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
> struct pt_regs *regs,
> int error, long val)
> {
> - if (error)
> - val = error;
> -
> - if (is_compat_thread(task_thread_info(task)))
> - val = lower_32_bits(val);
> -
> - regs->regs[0] = val;
> + regs->regs[0] = (long) error ? error : val;

= error ? (long)error : rval;

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)