Re: [PATCH] base: power: runtime.c: Remove a unnecessary space

[Sebastian Fricke]

Hey Joe,

On 18.04.2021 00:09, Joe Perches wrote:
> On Sun, 2021-04-18 at 06:08 +0000, Sebastian Fricke wrote:
> > Remove a redundant space to improve the quality of the comment.
>
> I think this patch is not useful.
>
> It's not redundant.

Thank you, I actually found this pattern a few more times but I wanted
to check first if this is a mistake or chosen consciously.

Sorry for the noise.

> Two spaces after a period is commonly used to separate sentences.
> It's especially common when used with fixed pitch fonts.
>
> A trivial grep seems to show it's used about 50K times in comments.
> Though single space after period may be used about twice as often.
>
> $ git grep '^\s*\*.*\.  [A-Z]' | wc -l
> 54439
> $ git grep '^\s*\*.*\. [A-Z]' | wc -l
> 110003
>
> For drivers/base/power/runtime.c, that 2 space after period style is used
> dozens of times and changing a single instance of it isn't very useful.

True and if I understand you correctly you would rather keep it as is
right?

Greetings,
Sebastian

> > ---
> > Side-note:
> > I found this while reading the code, I don't believe it is important but
> > I thought it doesn't hurt to fix it.
> > ---
> >  drivers/base/power/runtime.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> > index 18b82427d0cb..499434b84171 100644
> > --- a/drivers/base/power/runtime.c
> > +++ b/drivers/base/power/runtime.c
> > @@ -786,7 +786,7 @@ static int rpm_resume(struct device *dev, int rpmflags)
> >  	}
> >  
> >
> >  	/*
> > -	 * See if we can skip waking up the parent.  This is safe only if
> > +	 * See if we can skip waking up the parent. This is safe only if
> >  	 * power.no_callbacks is set, because otherwise we don't know whether
> >  	 * the resume will actually succeed.
> >  	 */