Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

From: Richard Cochran
Date: Sun Apr 18 2021 - 11:11:30 EST


On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote:
>
> How about not passing "clone" back to DSA as an argument by reference,
> but instead require the driver to populate DSA_SKB_CB(skb)->clone if it
> needs to do so?
>
> Also, how about changing the return type to void? Returning true or
> false makes no difference.

+1

Thanks,
Richard