Re: [PATCH v3 01/12] iommu: Introduce dirty log tracking framework

[Lu Baolu]

Hi Keqian,

On 4/16/21 5:07 PM, Keqian Zhu wrote:
> > I am worrying about having two sets of APIs for single purpose. From
> > vendor iommu driver's point of view, this feature is per device. Hence,
> > it still needs to do the same thing.
> Yes, we can unify the granule of feature reporting and status management.
>
> The basic granule of dirty tracking is iommu_domain, I think it's very reasonable. We need an
> interface to report the feature of iommu_domain, then the logic is much more clear.
>
> Every time we add new device or remove device from the domain, we should update the feature (e.g.,
> maintain a counter of unsupported devices).

Yes. This looks cleaner.

> What do you think about this idea?
>
> Thanks,
> Keqian

Best regards,
baolu