Re: [PATCH] powerpc/signal32: Fix build failure with CONFIG_SPE
From: Michael Ellerman
Date: Mon Apr 19 2021 - 00:04:21 EST
On Sun, 11 Apr 2021 16:39:53 +0000 (UTC), Christophe Leroy wrote:
> Add missing fault exit label in unsafe_copy_from_user() in order to
> avoid following build failure with CONFIG_SPE
>
> CC arch/powerpc/kernel/signal_32.o
> arch/powerpc/kernel/signal_32.c: In function 'restore_user_regs':
> arch/powerpc/kernel/signal_32.c:565:36: error: macro "unsafe_copy_from_user" requires 4 arguments, but only 3 given
> 565 | ELF_NEVRREG * sizeof(u32));
> | ^
> In file included from ./include/linux/uaccess.h:11,
> from ./include/linux/sched/task.h:11,
> from ./include/linux/sched/signal.h:9,
> from ./include/linux/rcuwait.h:6,
> from ./include/linux/percpu-rwsem.h:7,
> from ./include/linux/fs.h:33,
> from ./include/linux/huge_mm.h:8,
> from ./include/linux/mm.h:707,
> from arch/powerpc/kernel/signal_32.c:17:
> ./arch/powerpc/include/asm/uaccess.h:428: note: macro "unsafe_copy_from_user" defined here
> 428 | #define unsafe_copy_from_user(d, s, l, e) \
> |
> arch/powerpc/kernel/signal_32.c:564:3: error: 'unsafe_copy_from_user' undeclared (first use in this function); did you mean 'raw_copy_from_user'?
> 564 | unsafe_copy_from_user(current->thread.evr, &sr->mc_vregs,
> | ^~~~~~~~~~~~~~~~~~~~~
> | raw_copy_from_user
> arch/powerpc/kernel/signal_32.c:564:3: note: each undeclared identifier is reported only once for each function it appears in
> make[3]: *** [arch/powerpc/kernel/signal_32.o] Error 1
Applied to powerpc/next.
[1/1] powerpc/signal32: Fix build failure with CONFIG_SPE
https://git.kernel.org/powerpc/c/af072b1a9d4d9edc24da84a071b0671e147026cb
cheers