Re: [PATCH] kbuild: deb-pkg: change the source package name to 'linux'

[Ben Hutchings]

On Mon, 2021-04-19 at 16:01 +0900, Masahiro Yamada wrote:
> Change the source package name from 'linux-$(KERNELRELEASE)' to 'linux',
> which is aligned with the source package from the Debian community.

I would prefer that the source package name is *not* the same, so that
it is clearly distinguished from distribution packages.

Before commit 3716001bcb7f "deb-pkg: add source package" the binary
packages used to claim that the source package was "linux-upstream"
(although no such source package existed).  Could we use that instead?

Ben.

> The filenames will be changed as follows:
> 
> [before]
>   linux-5.12.0-rc3+_5.12.0-rc3+-1.dsc
>   linux-5.12.0-rc3+_5.12.0-rc3+.orig.tar.gz
>   linux-5.12.0-rc3+_5.12.0-rc3+-1.diff.gz
> 
> [After]
>   linux_5.12.0-rc3+-1.dsc
>   linux_5.12.0-rc3+.orig.tar.gz
>   linux_5.12.0-rc3+-1.diff.gz
> 
> Commit 3716001bcb7f ("deb-pkg: add source package") introduced
> KDEB_SOURCENAME. If you are unhappy with the default name, you can
> override it via KDEB_SOURCENAME.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
> 
>  scripts/Makefile.package | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index f952fb64789d..c5834a480545 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -25,7 +25,7 @@ include $(srctree)/scripts/Kbuild.include
>  
>  # Remove hyphens since they have special meaning in RPM filenames
>  KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
> -KDEB_SOURCENAME ?= linux-$(KERNELRELEASE)
> +KDEB_SOURCENAME ?= linux
>  KBUILD_PKG_ROOTCMD ?="fakeroot -u"
>  export KDEB_SOURCENAME
>  # Include only those top-level files that are needed by make, plus the GPL copy

-- 
Ben Hutchings
Humour is the best antidote to reality.

Attachment: signature.asc
Description: This is a digitally signed message part