RE: [PATCH v2 1/2] mmc: block: Issue flush only if allowed

[Avri Altman]

> 
> On Sun, 18 Apr 2021 at 08:00, Avri Altman <avri.altman@xxxxxxx> wrote:
> >
> > The cache may be flushed to the nonvolatile storage by writing to
> > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode,
> the
> > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a
> > FLUSH_CACHE op-code.  Either way, verify that The cache function is
> > turned ON before doing so.
> 
> Avri, thanks for your patch. Overall this looks good to me.
> 
> However things are becoming more and more messy in these layers of the
> mmc core. In particular, I would like us to take advantage of the
> bus_ops callbacks, when eMMC and/or SD specific features need
> different implementations.
> 
> I have posted a patch [1], that moves the eMMC cache flushing into a
> bus_ops callback. Would you mind rebasing this series on top of that?
Sure.

Thanks,
Avri

> 
> Kind regards
> Uffe
> 
> [1]
> https://patchwork.kernel.org/project/linux-
> mmc/patch/20210419122943.68234-1-ulf.hansson@xxxxxxxxxx/