Re: [PATCH 0/2] Change struct page layout for page_pool

From: Michael Ellerman
Date: Tue Apr 20 2021 - 00:04:37 EST


"Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> writes:
> The first patch here fixes two bugs on ppc32, and mips32. It fixes one
> bug on arc and arm32 (in certain configurations). It probably makes
> sense to get it in ASAP through the networking tree. I'd like to see
> testing on those four architectures if possible?

Sorry I don't have easy access to any hardware that fits the bill. At
some point I'll be able to go to the office and setup a machine that (I
think) can test these paths, but I don't have an ETA on that.

You and others seem to have done lots of analysis on this though, so I
think you should merge the fixes without waiting on ppc32 testing.

cheers


>
> The second patch enables new functionality. It is much less urgent.
> I'd really like to see Mel & Michal's thoughts on it.
>
> I have only compile-tested these patches.
>
> Matthew Wilcox (Oracle) (2):
> mm: Fix struct page layout on 32-bit systems
> mm: Indicate pfmemalloc pages in compound_head
>
> include/linux/mm.h | 12 +++++++-----
> include/linux/mm_types.h | 9 ++++-----
> include/net/page_pool.h | 12 +++++++++++-
> net/core/page_pool.c | 12 +++++++-----
> 4 files changed, 29 insertions(+), 16 deletions(-)
>
> --
> 2.30.2