Re: [PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming

[Fabio Aiuto]

Hi,

On Tue, Apr 20, 2021 at 12:45:57AM +0530, Deepak R Varma wrote:
> Mixed case variable names are discouraged and they result in checkpatch
> script "Avoid CamelCase" warnings. Replace such CamelCase variable names
> by lower case strings according to the coding style guidelines.
> 
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> ---
>  .../media/atomisp/i2c/atomisp-mt9m114.c       | 62 +++++++++----------
>  1 file changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> index 160bb58ce708..e63906a69e30 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> @@ -999,10 +999,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
>  	struct mt9m114_device *dev = to_mt9m114_sensor(sd);
>  	int ret = 0;
>  	unsigned int coarse_integration = 0;
> -	unsigned int FLines = 0;
> -	unsigned int FrameLengthLines = 0; /* ExposureTime.FrameLengthLines; */
> -	unsigned int AnalogGain, DigitalGain;
> -	u32 AnalogGainToWrite = 0;
> +	unsigned int f_lines = 0;
> +	unsigned int frame_len_lines = 0; /* ExposureTime.FrameLengthLines; */
> +	unsigned int analog_gain, digital_gain;
> +	u32 analog_gain_to_write = 0;
> 

this patch is made of multiple logical changes, i.e. more than one
variable at a time are renamed. Maybe this should be split in
one patch per variable name.

thank you,

fabio