Re: [PATCH net-next 09/10] net: sparx5: add ethtool configuration and statistics support

[Steen.Hegelund]

Hi Jacub,

On Fri, 2021-04-16 at 14:26 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, 16 Apr 2021 15:16:56 +0200 Steen Hegelund wrote:
> > +     "rx_in_bytes",
> > +     "rx_symbol_err",
> > +     "rx_pause",
> > +     "rx_unsup_opcode",
> > +     "rx_ok_bytes",
> > +     "rx_bad_bytes",
> > +     "rx_unicast",
> > +     "rx_multicast",
> > +     "rx_broadcast",
> > +     "rx_crc_err",
> > +     "rx_undersize",
> > +     "rx_fragments",
> > +     "rx_inrangelen_err",
> > +     "rx_outofrangelen_err",
> > +     "rx_oversize",
> > +     "rx_jabbers",
> > +     "rx_size64",
> > +     "rx_size65_127",
> > +     "rx_size128_255",
> > +     "rx_size256_511",
> > +     "rx_size512_1023",
> > +     "rx_size1024_1518",
> > +     "rx_size1519_max",
> > +     "pmac_rx_symbol_err",
> > +     "pmac_rx_pause",
> > +     "pmac_rx_unsup_opcode",
> > +     "pmac_rx_ok_bytes",
> > +     "pmac_rx_bad_bytes",
> > +     "pmac_rx_unicast",
> > +     "pmac_rx_multicast",
> > +     "pmac_rx_broadcast",
> > +     "pmac_rx_crc_err",
> > +     "pmac_rx_undersize",
> > +     "pmac_rx_fragments",
> > +     "pmac_rx_inrangelen_err",
> > +     "pmac_rx_outofrangelen_err",
> > +     "pmac_rx_oversize",
> > +     "pmac_rx_jabbers",
> > +     "pmac_rx_size64",
> > +     "pmac_rx_size65_127",
> > +     "pmac_rx_size128_255",
> > +     "pmac_rx_size256_511",
> > +     "pmac_rx_size512_1023",
> > +     "pmac_rx_size1024_1518",
> > +     "pmac_rx_size1519_max",
> > +     "rx_local_drop",
> > +     "rx_port_policer_drop",
> > +     "tx_out_bytes",
> > +     "tx_pause",
> > +     "tx_ok_bytes",
> > +     "tx_unicast",
> > +     "tx_multicast",
> > +     "tx_broadcast",
> > +     "tx_size64",
> > +     "tx_size65_127",
> > +     "tx_size128_255",
> > +     "tx_size256_511",
> > +     "tx_size512_1023",
> > +     "tx_size1024_1518",
> > +     "tx_size1519_max",
> > +     "tx_multi_coll",
> > +     "tx_late_coll",
> > +     "tx_xcoll",
> > +     "tx_defer",
> > +     "tx_xdefer",
> > +     "tx_backoff1",
> > +     "pmac_tx_pause",
> > +     "pmac_tx_ok_bytes",
> > +     "pmac_tx_unicast",
> > +     "pmac_tx_multicast",
> > +     "pmac_tx_broadcast",
> > +     "pmac_tx_size64",
> > +     "pmac_tx_size65_127",
> > +     "pmac_tx_size128_255",
> > +     "pmac_tx_size256_511",
> > +     "pmac_tx_size512_1023",
> > +     "pmac_tx_size1024_1518",
> > +     "pmac_tx_size1519_max",
> 
> Please see
> 
> https://patchwork.kernel.org/project/netdevbpf/list/?series=468795
> 
> (hopefully to be merged by the end of the week) and earlier patches for
> pause and FEC stats. Anything that has a standardized interface is off
> limits for the random ethtool -S grab bag.

OK.  I was not aware of that.

Thanks for your comments.

Best Regards
Steen