Re: [PATCH] KVM: selftests: Always run vCPU thread with blocked SIG_IPI

From: Peter Xu
Date: Tue Apr 20 2021 - 10:37:47 EST


On Tue, Apr 20, 2021 at 04:16:14AM -0400, Paolo Bonzini wrote:
> The main thread could start to send SIG_IPI at any time, even before signal
> blocked on vcpu thread. Therefore, start the vcpu thread with the signal
> blocked.
>
> Without this patch, on very busy cores the dirty_log_test could fail directly
> on receiving a SIGUSR1 without a handler (when vcpu runs far slower than main).
>
> Reported-by: Peter Xu <peterx@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Yes, indeed better! :)

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

--
Peter Xu