Re: [PATCH 2/2] rcu/tree_plugin: don't handle the case of 'all' CPU range

From: Yury Norov
Date: Tue Apr 20 2021 - 15:38:53 EST


On Tue, Apr 20, 2021 at 01:18:40PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 19, 2021 at 05:01:31PM -0700, Yury Norov wrote:
> > The 'all' semantics is now supported by the bitmap_parselist() so we can
> > drop supporting it as a special case in RCU code. This patch does not
> > add any functional changes for existing users.
>
> > - if (!strcasecmp(str, "all")) /* legacy: use "0-N" instead */
>
> Perhaps move comment as well to new location.

I actually wanted to remove this comment. The reason is that 'all' is
verbose, clear and proven to be useful for at least RCU. In v2 I'll
mention it explicitly in commit comment.