Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Tue Apr 20 2021 - 16:09:41 EST


Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:25, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> net/tipc/link.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/tipc/link.c b/net/tipc/link.c
> index 115109259430..bcc426e16725 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
> break;
> case LINK_FAILOVER_BEGIN_EVT:
> l->state = LINK_FAILINGOVER;
> + break;
> case LINK_FAILURE_EVT:
> case LINK_RESET_EVT:
> case LINK_ESTABLISH_EVT:
>