RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

[Salil Mehta]

> From: Brelinski, TonyX [mailto:tonyx.brelinski@xxxxxxxxx]
> Sent: Tuesday, April 20, 2021 9:26 PM
> 
> > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> > Salil Mehta
> > Sent: Tuesday, April 13, 2021 3:45 PM
> > To: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx
> > Cc: salil.mehta@xxxxxxxxxx; linuxarm@xxxxxxxxxxxxx;
> > netdev@xxxxxxxxxxxxxxx; linuxarm@xxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>; intel-
> > wired-lan@xxxxxxxxxxxxxxxx
> > Subject: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R,
> > T}XQ check/code for efficiency+readability
> >
> > If user has explicitly requested the number of {R,T}XQs, then it is
> > unnecessary to get the count of already available {R,T}XQs from the PF
> > avail_{r,t}xqs bitmap. This value will get overridden by user specified value
> in
> > any case.
> >
> > This patch does minor re-organization of the code for improving the flow and
> > readabiltiy. This scope of improvement was found during the review of the
> > ICE driver code.
> >
> > FYI, I could not test this change due to unavailability of the hardware.
> > It would be helpful if somebody can test this patch and provide Tested-by
> > Tag. Many thanks!
> >
> > Fixes: 87324e747fde ("ice: Implement ethtool ops for channels")
> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> > Signed-off-by: Salil Mehta <salil.mehta@xxxxxxxxxx>
> > --
> > Change V1->V2
> >  (*) Fixed the comments from Anthony Nguyen(Intel)
> >      Link: https://lkml.org/lkml/2021/4/12/1997
> > ---
> >  drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> Tested-by: Tony Brelinski <tonyx.brelinski@xxxxxxxxx> (A Contingent Worker at
> Intel)

Many thanks! 

Salil.