Re: [PATCH V2 4/4] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml

[skakit]

Hi Rob,

On 2021-04-10 00:20, Rob Herring wrote:
> On Thu, Apr 08, 2021 at 05:01:09PM +0530, satya priya wrote:
> > Convert qcom pm8941 power key binding from .txt to .yaml format.
> >
> > Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
[...]
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,pm8941-pwrkey
> > +      - qcom,pm8941-resin
> > +      - qcom,pmk8350-pwrkey
> > +      - qcom,pmk8350-resin
> > +
> > +  interrupts:
>
> How many?

ok, will add maxItems.

> > +    description: |
> > +          Key change interrupt; The format of the specifier is
> > +          defined by the binding document describing the node's
> > +          interrupt parent.
>
> The 2nd sentence is every 'interrupts' property. Drop.

Will remove the description.

> > +
> > +  debounce:
> > +    description: |
> > +          Time in microseconds that key must be pressed or
> > +          released for state change interrupt to trigger.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  bias-pull-up:
> > +    description: |
> > +           Presence of this property indicates that the KPDPWR_N
> > +           pin should be configured for pull up.
> > +    $ref: /schemas/types.yaml#/definitions/flag
> > +
> > +  linux,code:
> > +    description: |
> > +           The input key-code associated with the power key.
> > +           Use the linux event codes defined in
> > +           include/dt-bindings/input/linux-event-codes.h
> > +           When property is omitted KEY_POWER is assumed.
> > +    $ref: "input.yaml#"
>
> You've just defined that 'linux,code' is a node with properties defined
> in input.yaml. Need to move this up to the top level.

allOf:
  $ref: "input.yaml#"
That means I should add like this at the beginning? please correct me if 
wrong.

> > +
> > +required:
> > +  - compatible
> > +  - interrupts
> > +
> > +additionalProperties: false
[...]

Thanks,
Satya Priya