Re: [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs'

[Christian König]

Am 20.04.21 um 23:27 schrieb Alex Deucher:
> On Fri, Apr 16, 2021 at 11:32 AM Christian König
> <christian.koenig@xxxxxxx> wrote:
> > Am 16.04.21 um 16:37 schrieb Lee Jones:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > >    drivers/gpu/drm/ttm/ttm_bo.c:293: warning: expecting prototype for function ttm_bo_cleanup_refs(). Prototype was for ttm_bo_cleanup_refs() instead
> > >
> > > Cc: Christian Koenig <christian.koenig@xxxxxxx>
> > > Cc: Huang Rui <ray.huang@xxxxxxx>
> > > Cc: David Airlie <airlied@xxxxxxxx>
> > > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > Cc: linux-media@xxxxxxxxxxxxxxx
> > > Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > Reviewed-by: Christian König <christian.koenig@xxxxxxx>
> Can you push the ttm and sched fixes to drm-misc?

Yes, Daniel already pinged me about that as well.

Christian.

> Alex
>
>
> > > ---
> > >    drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> > > index cfd0b92923973..defec9487e1de 100644
> > > --- a/drivers/gpu/drm/ttm/ttm_bo.c
> > > +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> > > @@ -274,7 +274,7 @@ static void ttm_bo_flush_all_fences(struct ttm_buffer_object *bo)
> > >    }
> > >
> > >    /**
> > > - * function ttm_bo_cleanup_refs
> > > + * ttm_bo_cleanup_refs
> > >     * If bo idle, remove from lru lists, and unref.
> > >     * If not idle, block if possible.
> > >     *
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Cf8fdcfa489074adeaf5c08d9044311cc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637545508403690573%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Fq7MSyZmno%2By0o%2F%2BLO6NjM0C0%2BnKA2Ml2oPMmcJJ7AA%3D&amp;reserved=0