Re: [PATCH 1/1] dt-bindings: serial: Add label property for pl011

[Leizhen (ThunderTown)]

On 2021/4/21 4:02, Rob Herring wrote:
> On Thu, Apr 15, 2021 at 03:31:05PM +0800, Zhen Lei wrote:
>> When there is more than one pl011 serial port present, the label property
>> allows a custom name to be used for briefly describe the usage or position
>> of each serial port.
>>
>> Without this "label" property, many dtbs_check warnings similar to the
>> following are reported:
>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \
>> serial@ffd74000: Additional properties are not allowed ('label' was unexpected)
>>         From schema: Documentation/devicetree/bindings/serial/pl011.yaml
> 
> I think this should go into serial.yaml instead.

Yes，But if I add "label: true" into serial.yaml, it doesn't work. I haven't figured out why.

By the way, should "$ref: /schemas/serial.yaml#" be replaced with "$ref: /schemas/serial/serial.yaml#"?

> 
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/serial/pl011.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
>> index 1f8e9f2644b6b80..303c7746423f503 100644
>> --- a/Documentation/devicetree/bindings/serial/pl011.yaml
>> +++ b/Documentation/devicetree/bindings/serial/pl011.yaml
>> @@ -34,6 +34,9 @@ properties:
>>    reg:
>>      maxItems: 1
>>  
>> +  label:
>> +    maxItems: 1
> 
> label is always a single string and so 'maxItems' is always 1. Just 
> need:
> 
> label: true

OK

> 
>> +
>>    interrupts:
>>      maxItems: 1
>>  
>> -- 
>> 2.26.0.106.g9fadedd
>>
>>
> 
> .
>