Re: [PATCH v3 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.

[Kuniyuki Iwashima]

From:   Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
Date:   Tue, 20 Apr 2021 15:57:54 -0700
> On Tue, Apr 20, 2021 at 8:45 AM Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx> wrote:
> >
> > This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE and
> > removes 'static' from settimeo() in network_helpers.c.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx>
> > ---
> 
> Almost everything in prog_tests/migrate_reuseport.c should be static,
> functions and variables. Except the test_migrate_reuseport, of course.
> 
> But thank you for using ASSERT_xxx()! :)

Ah, I'll fix them in the next spin :)
Thank you!


> 
> >  tools/testing/selftests/bpf/network_helpers.c |   2 +-
> >  tools/testing/selftests/bpf/network_helpers.h |   1 +
> >  .../bpf/prog_tests/migrate_reuseport.c        | 483 ++++++++++++++++++
> >  .../bpf/progs/test_migrate_reuseport.c        |  51 ++
> >  4 files changed, 536 insertions(+), 1 deletion(-)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/test_migrate_reuseport.c
> >
> 
> [...]