RE: [PATCH v2 1/5] scsi: BusLogic: Fix missing `pr_cont' use

From: Maciej W. Rozycki
Date: Wed Apr 21 2021 - 08:28:48 EST


On Wed, 21 Apr 2021, David Laight wrote:

> > Update BusLogic driver's messaging system to use `pr_cont' for
> > continuation lines, bringing messy output:
>
> If reasonably possible it is best to avoid use of pr_cont().

I know, however for that the whole driver's messaging system would have
to be redesigned. Joe (cc-ed) has offered to do it with the original
iteration, however I believe consensus has been it will best be done as a
separate follow-up change, while this small fix can be easily backported.

> If there are concurrent writes from multiple cpu I believe
> the writes still get separated.
> (Something has to give...)

NB this driver may not see a lot of SMP use as I reckon it's had some
portability issues, and in any case the hardware requires port I/O which
precludes its use with some of the most recent PCIe systems which do not
support PCI I/O cycles anymore. And older systems were often UP. Not
that the driver should not be kept in a clean style of course.

Maciej