Aw: Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label
From: Frank Wunderlich
Date: Wed Apr 21 2021 - 10:05:13 EST
Hi,
for dsa slave-ports there is already a property "label", but not for master/cpu-ports
https://elixir.bootlin.com/linux/v5.12-rc8/source/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts#L163
handled here:
https://elixir.bootlin.com/linux/v5.12-rc8/source/net/dsa/dsa2.c#L1113
@ilya maybe you can rename slave-ports instead of master-port without code change?
i also prefer a more generic way to name interfaces in dts, not only in the mtk-driver, but the udev-approach is a way too, but this needs to be configured on each system manually...a preset by kernel/dts will be nice (at least to distinguish master/cpu- and user-ports).
regards Frank