Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support

[Zanussi, Tom]

On 4/21/2021 10:03 AM, Vinod Koul wrote:
> On 21-04-21, 07:50, Zanussi, Tom wrote:
>
> > > > > > +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > > > > > +			    char *buf);
> > > > > > +
> > > > > > +static cpumask_t		perfmon_dsa_cpu_mask;
> > > > > > +static bool			cpuhp_set_up;
> > > > > > +static enum cpuhp_state		cpuhp_slot;
> > > > > > +
> > > > > > +static DEVICE_ATTR_RO(cpumask);
> > > > >
> > > > > Pls document these new attributes added
> > >
> > > ?
> >
> > Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).
>
> They need to be, all new sysfs attributes are ABI and need to be
> documented in Documentation/ABI/

OK, will do that as well, thanks for letting me know.

Tom

> Thanks