Re: [PATCH 1/2] dt-bindings: watchdog: gpio-wdt: add "start-at-boot"

[Guenter Roeck]

On Wed, Apr 21, 2021 at 06:26:20PM +0200, Francesco Zanella wrote:
> Documentation for new device tree property "start-at-boot".
> 
> Signed-off-by: Francesco Zanella <francesco.zanella@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/watchdog/gpio-wdt.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
> index 198794963786..cdaf7f0602e8 100644
> --- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
> @@ -17,6 +17,13 @@ Optional Properties:
>  - always-running: If the watchdog timer cannot be disabled, add this flag to
>    have the driver keep toggling the signal without a client. It will only cease
>    to toggle the signal when the device is open and the timeout elapsed.
> +- start-at-boot: Start pinging hw watchdog at probe, in order to take advantage
> +  of kernel configs:
> +  - WATCHDOG_HANDLE_BOOT_ENABLED: Avoid possible reboot if hw watchdog was been
> +    enabled before the kernel (by uboot for example) and userspace doesn't take
> +    control of /dev/watchdog in time;
> +  - WATCHDOG_OPEN_TIMEOUT: Reboot if userspace doesn't take control of
> +    /dev/watchdog within the timeout.

You are not supposed to refer to Linux kernel details in devicetree
bindings documents.

Guenter

>  
>  Example:
>  	watchdog: watchdog {
> -- 
> 2.17.1
>