Re: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device supports it

[Kai-Heng Feng]

On Wed, Apr 21, 2021 at 4:42 PM Liang, Prike <Prike.Liang@xxxxxxx> wrote:
>
> [AMD Public Use]
>
> According to BIOS guys the _PR3 should be always implemented for NVMe device on the onwards ASIC. This solution seems more simple and looks good to me.

Turns out ASUS laptops don't have _PR3 implement in ACPI, so this
patch doesn't work on them.
For now, please use the patch from AMD instead, thanks!

Kai-Heng

>
> Reviewed-by: Prike Liang <Prike.Liang@xxxxxxx>
>
> Thanks,
> Prike
> > -----Original Message-----
> > From: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> > Sent: Monday, April 19, 2021 2:58 PM
> > To: Christoph Hellwig <hch@xxxxxx>
> > Cc: Keith Busch <kbusch@xxxxxxxxxx>; Jens Axboe <axboe@xxxxxx>; Sagi
> > Grimberg <sagi@xxxxxxxxxxx>; Deucher, Alexander
> > <Alexander.Deucher@xxxxxxx>; Liang, Prike <Prike.Liang@xxxxxxx>; S-k,
> > Shyam-sundar <Shyam-sundar.S-k@xxxxxxx>; open list:NVM EXPRESS
> > DRIVER <linux-nvme@xxxxxxxxxxxxxxxxxxx>; open list <linux-
> > kernel@xxxxxxxxxxxxxxx>
> > Subject: Re: [PATCH v2] nvme: Favor D3cold for suspend if NVMe device
> > supports it
> >
> > On Mon, Apr 19, 2021 at 2:50 PM Christoph Hellwig <hch@xxxxxx> wrote:
> > >
> > > On Fri, Apr 16, 2021 at 05:13:44PM +0800, Kai-Heng Feng wrote:
> > > > On AMD platforms that use s2idle, NVMe timeouts on s2idle resume,
> > > > because their SMU FW may cut off NVMe power during sleep.
> > >
> > > We're already have a discussion on a proper quirk for thse broken
> > > platforms on the linux-nvme list, please take part in that discussion.
> >
> > Thanks. I didn't notice v5 was sent the to mailing list.
> > As of now, AMD folks are also reviewing this, and I believe this approach is
> > less quirky.
> >
> > Kai-Heng