Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang

[Jeffrey E Altman]

On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@xxxxxxxxxx) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple fallthrough pseudo-keywords
> in places where the code is intended to fall through to the next
> case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> Changes in v2:
>   - Place blank line after the fallthrough markings, not before.
>     Link: https://lore.kernel.org/linux-hardening/748935.1606147853@xxxxxxxxxxxxxxxxxxxxxx/

This change looks good to me.

Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>


begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@xxxxxxxxxxxx
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard

Attachment: OpenPGP_signature
Description: OpenPGP digital signature