Re: [PATCH v4 4/4] pinctrl: add rsel setting on MT8195

From: zhiyong tao
Date: Wed Apr 21 2021 - 22:11:02 EST


On Tue, 2021-04-20 at 11:50 +0800, Sean Wang wrote:
> On Mon, Apr 12, 2021 at 10:57 PM Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> wrote:
>
> <snip>
> > @@ -176,6 +180,12 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> > else
> > err = -ENOTSUPP;
> > break;
> > + case MTK_PIN_CONFIG_RSEL:
> > + if (hw->soc->rsel_get)
> > + err = hw->soc->rsel_get(hw, desc, &ret);
> > + else
> > + err = -EOPNOTSUPP;
>
> I think that should want to be -ENOTSUPP to align other occurrences.
==>Hi sean,
Can you give me some suggestion? -ENOPARAM or -EBADTYPE?

Thanks.
>
> > + break;
> > default:
> > err = -ENOTSUPP;
> > }
> > @@ -295,6 +305,12 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
> > else
> > err = -ENOTSUPP;
> > break;
> > + case MTK_PIN_CONFIG_RSEL:
> > + if (hw->soc->rsel_set)
> > + err = hw->soc->rsel_set(hw, desc, arg);
> > + else
> > + err = -EOPNOTSUPP;
>
> Ditto
>
> > + break;
> > default:
> > err = -ENOTSUPP;
> > }
> > --
> > 2.18.0
> >