Re: [PATCH 121/190] Revert "serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference"

[Jiri Slaby]

On 21. 04. 21, 14:59, Greg Kroah-Hartman wrote:
> This reverts commit 32f47179833b63de72427131169809065db6745e.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Aditya Pakki <pakki001@xxxxxxx>
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>   drivers/tty/serial/mvebu-uart.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index e0c00a1b0763..51b0ecabf2ec 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -818,9 +818,6 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	if (!match)
> -		return -ENODEV;

The original fix doesn't hurt, but is useless. ->probe is called when 
of_match_device matched.

So the revert is OK.

>   	/* Assume that all UART ports have a DT alias or none has */
>   	id = of_alias_get_id(pdev->dev.of_node, "serial");
>   	if (!pdev->dev.of_node || id < 0)


--
js
suse labs