Re: [PATCH 1/1] dt-bindings: serial: Add label property for pl011

[Leizhen (ThunderTown)]

On 2021/4/22 11:10, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/4/21 21:53, Rob Herring wrote:
>> On Wed, Apr 21, 2021 at 4:38 AM Leizhen (ThunderTown)
>> <thunder.leizhen@xxxxxxxxxx> wrote:
>>>
>>>
>>>
>>> On 2021/4/21 4:02, Rob Herring wrote:
>>>> On Thu, Apr 15, 2021 at 03:31:05PM +0800, Zhen Lei wrote:
>>>>> When there is more than one pl011 serial port present, the label property
>>>>> allows a custom name to be used for briefly describe the usage or position
>>>>> of each serial port.
>>>>>
>>>>> Without this "label" property, many dtbs_check warnings similar to the
>>>>> following are reported:
>>>>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \
>>>>> serial@ffd74000: Additional properties are not allowed ('label' was unexpected)
>>>>>         From schema: Documentation/devicetree/bindings/serial/pl011.yaml
>>>>
>>>> I think this should go into serial.yaml instead.
>>>
>>> Yes，But if I add "label: true" into serial.yaml, it doesn't work. I haven't figured out why.
>>
>> Change the 'additionalProperties: false' to 'unevaluatedProperties: false'.
> 
> Wow, it works. I admire you so much. You're a master.
> 
>>
>>> By the way, should "$ref: /schemas/serial.yaml#" be replaced with "$ref: /schemas/serial/serial.yaml#"?
>>
>> Oh, yes! Looks like it should be fixed for the other serial schemas
>> too. There is a /schemas/serial.yaml schema from dt-schema which
>> predates the kernel one, but it just has the $nodename. The kernel one
>> is much more complete.
> 
> All right, I'll fix them all.

I checked all YAML files in directory Documentation/devicetree/bindings/serial/,
except pl011.yaml, all that need to be modified are modified. No similar
('xxx' was unexpected) warnings are reported.

> 
>>
>> Rob
>>
>> .
>>