Re: [RFC PATCH linux-next] kernel/resource: __region_intersects() can be static

[Andy Shevchenko]

On Thu, Apr 22, 2021 at 4:30 AM kernel test robot <lkp@xxxxxxxxx> wrote:

Can you generate a commit message as well?
Otherwise looks valid to me, thanks!

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Fixes: edede6a2ecfe ("kernel/resource: allow region_intersects users to hold resource_lock")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> ---
>  resource.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 8faae19f8236e..a4bc6f66136c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -502,8 +502,8 @@ int __weak page_is_ram(unsigned long pfn)
>  }
>  EXPORT_SYMBOL_GPL(page_is_ram);
>
> -int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> -                       unsigned long desc)
> +static int __region_intersects(resource_size_t start, size_t size, unsigned long flags,
> +                              unsigned long desc)
>  {
>         struct resource res;
>         int type = 0; int other = 0;



-- 
With Best Regards,
Andy Shevchenko