Re: [PATCH v2] hwrng: exynos - Fix runtime PM imbalance on error

[Łukasz Stelmach]

It was <2021-04-22 czw 12:46>, when Krzysztof Kozlowski wrote:
> On 22/04/2021 12:41, Łukasz Stelmach wrote:
>> pm_runtime_get_sync() increments the runtime PM usage counter even
>> the call returns an error code. Thus a pairing decrement is needed
>> on the error handling path to keep the counter balanced.
>
> It's exactly the same as Dinghao's patch:
> https://lore.kernel.org/linux-samsung-soc/20200522011659.26727-1-dinghao.liu@xxxxxxxxxx/
> which you reviewed. It has even the same commit msg
> (although it's difficult to be creative here).
>
> I think it's better to resend his patch instead.

It isn't the same because it uses pm_runtime_put_noidle() as discussed
here[1], applied here[2] and advised here[2]. Dinghao didn't prepare
v3[4] for exynos.

[1] https://lore.kernel.org/lkml/20200528065519.GA26960@xxxxxxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/lkml/20200528072106.5191-1-dinghao.liu@xxxxxxxxxx/
[3] https://lore.kernel.org/lkml/20200616073142.GA30519@xxxxxxxxxxxxxxxxxxx/
[4] https://lore.kernel.org/lkml/20200522011659.26727-1-dinghao.liu@xxxxxxxxxx/
-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Attachment: signature.asc
Description: PGP signature