Re: [PATCH 0/2] arm64: ACPI GTDT watchdog fixes

From: Lorenzo Pieralisi
Date: Thu Apr 22 2021 - 10:23:57 EST


On Wed, Apr 21, 2021 at 05:43:15PM +0100, Marc Zyngier wrote:
> Dann recently reported that his ThunderX machine failed to boot since
> 64b499d8df40 ("irqchip/gic-v3: Configure SGIs as standard
> interrupts"), with a not so pretty crash while trying to send an IPI.
>
> It turned out to be caused by a mix of broken firmware and a buggy
> GTDT watchdog driver. Both have forever been buggy, but the above
> commit revealed that the error handling path of the driver was
> probably the worse part of it all.
>
> Anyway, this short series has two goals:
> - handle broken firmware in a less broken way
> - make sure that the route cause of the problem can be identified
> quickly
>
> Thanks,
>
> M.
>
> Marc Zyngier (2):
> ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
> ACPI: irq: Prevent unregistering of GIC SGIs
>
> drivers/acpi/arm64/gtdt.c | 10 ++++++----
> drivers/acpi/irq.c | 6 +++++-
> 2 files changed, 11 insertions(+), 5 deletions(-)

Patch(2) needs an ACK from Rafael - usually these patches go via
the ARM64 tree but I don't think it is compulsory for this series.

Thank you !

Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>