Re: [PATCH] staging: rtl8723bs: avoid bogus gcc warning

[Dan Carpenter]

On Thu, Apr 22, 2021 at 03:32:04PM +0200, Arnd Bergmann wrote:
> @@ -762,7 +764,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa
>  		}
>  
>  	}
> -

Since you're going to need to redo this, then please don't do this
unrelated whitespace change.

>  exit:
>  
>  	return ret;
> @@ -885,8 +886,10 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, struct ieee_param
>  					if (strcmp(param->u.crypt.alg, "TKIP") == 0 || strcmp(param->u.crypt.alg, "CCMP") == 0)
>  					{
>  						memcpy(padapter->securitypriv.dot118021XGrpKey[param->u.crypt.idx].skey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len));
> +#if 1

These seems unintetional?

>  						memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.idx].skey, &(param->u.crypt.key[16]), 8);
>  						memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.idx].skey, &(param->u.crypt.key[24]), 8);
> +#endif
>  	                                        padapter->securitypriv.binstallGrpkey = true;
>  
>  						padapter->securitypriv.dot118021XGrpKeyid = param->u.crypt.idx;

regards,
dan carpenter