Re: [PATCH] Input: rework USB Kconfig dependencies

[Randy Dunlap]

On 4/22/21 6:36 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> A lot of input drivers traditionally depend on CONFIG_USB_ARCH_HAS_HCD
> and select CONFIG_USB. This works but is different from almost every
> other subsystem in the kernel.
> 
> I found this when debugging a build failure in the RC subsystem that
> had the same logic.
> 
> The problem here is that CONFIG_USB_ARCH_HAS_HCD no longer has
> a meaning since the host controller support has been changed to
> use machine specific loadable modules for the USB host. Selecting
> a subsystem that a driver needs is confusing and can lead to
> recursive dependency chains in Kconfig.
> 
> In both cases, the normal logic is to specify 'depends on USB'.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>  drivers/input/joystick/Kconfig    |  6 ++----
>  drivers/input/misc/Kconfig        | 15 +++++----------
>  drivers/input/mouse/Kconfig       |  9 +++------
>  drivers/input/tablet/Kconfig      | 15 +++++----------
>  drivers/input/touchscreen/Kconfig |  3 +--
>  5 files changed, 16 insertions(+), 32 deletions(-)
> 


-- 
~Randy