Re: [PATCH] tools/cgroup/slabinfo.py: updated to work on current kernel

From: Roman Gushchin
Date: Thu Apr 22 2021 - 20:53:16 EST


On Thu, Apr 22, 2021 at 08:29:31AM +0300, Vasily Averin wrote:
> slabinfo.py script does not work with actual kernel version.
> First, it was unable to recognise SLUB susbsytem,
> when I specified it manually, it was failed again with
> AttributeError: 'struct page' has no member 'obj_cgroups'
> ... and then again with
> File "tools/cgroup/memcg_slabinfo.py", line 221, in main
> memcg.kmem_caches.address_of_(),
> AttributeError: 'struct mem_cgroup' has no member 'kmem_caches'
>
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>

Indeed, we forgot to update it after recent changes in page->memcg_data.
Thank you, Vasily, for updating it!

I tested it, and it works great for me. Please, feel free to add
Tested-by: Roman Gushchin <guro@xxxxxx>
Acked-by: Roman Gushchin <guro@xxxxxx>

Thanks!