Re: [PATCH] soc: qcom-geni-se: remove redundant initialization to variable line

[Jiri Slaby]

On 22. 04. 21, 14:58, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable line being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> ---
>   drivers/tty/serial/qcom_geni_serial.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 99375d99f6fa..c5f2a4fa2bb1 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1338,7 +1338,7 @@ static const struct uart_ops qcom_geni_uart_pops = {
>   static int qcom_geni_serial_probe(struct platform_device *pdev)
>   {
>   	int ret = 0;
> -	int line = -1;
> +	int line;
>   	struct qcom_geni_serial_port *port;
>   	struct uart_port *uport;
>   	struct resource *res;


--
js
suse labs