Re: [PATCH v1 2/8] spi: rockchip: add compatible string for rv1126

[Heiko Stübner]

Hi Jon,

Am Freitag, 23. April 2021, 10:41:49 CEST schrieb Jon Lin:
> Add compatible string for rv1126 to applications for potential
> applications.
> 
> Signed-off-by: Jon Lin <jon.lin@xxxxxxxxxxxxxx>
> ---
>  drivers/spi/spi-rockchip.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index 52d6259d96ed..dae0281f6ba8 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -911,7 +911,9 @@ static const struct dev_pm_ops rockchip_spi_pm = {
>  };
>  
>  static const struct of_device_id rockchip_spi_dt_match[] = {
> -	{ .compatible = "rockchip,px30-spi", },
> +	{ .compatible = "rockchip,px30-spi",   },

unrelated change with the add "space" at the end

> +	{ .compatible = "rockchip,rv1108-spi", },
> +	{ .compatible = "rockchip,rv1126-spi", },

it seems the list was sorted alphabetically, so rv* comes after rk*
which is probably why the rv1108 was at the bottom and rightfully so.


Heiko

>  	{ .compatible = "rockchip,rk3036-spi", },
>  	{ .compatible = "rockchip,rk3066-spi", },
>  	{ .compatible = "rockchip,rk3188-spi", },
> @@ -921,7 +923,6 @@ static const struct of_device_id rockchip_spi_dt_match[] = {
>  	{ .compatible = "rockchip,rk3328-spi", },
>  	{ .compatible = "rockchip,rk3368-spi", },
>  	{ .compatible = "rockchip,rk3399-spi", },
> -	{ .compatible = "rockchip,rv1108-spi", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match);
>