Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

[Chen Yu]

On Fri, Apr 23, 2021 at 10:04:10AM -0400, Calvin Walton wrote:
> On Fri, 2021-04-23 at 20:16 +0800, Chen Yu wrote
> > 
> > Calvin, could you please take a look at the following version if it
> > is suitible?
> 
> I assume this patch is adapted from my earlier submission of the
> complete fix to be an incremental fix on top of the already applied
> patch? If so, you are OK to add
> 
> Signed-off-by: Calvin Walton <calvin.walton@xxxxxxxxxx>
>
Thanks Calvin. BTW, I did not receive your incremental patch on top of
already applied one, so I post this patch in the name of yours. 
> > From b2e63fe4f02e17289414b4f61237da822df115fb Mon Sep 17 00:00:00
> > 2001
> > From: Calvin Walton <calvin.walton@xxxxxxxxxx>
> > Date: Fri, 23 Apr 2021 17:32:13 +0800
> > Subject: [PATCH 3/5] tools/power turbostat: Fix offset overflow issue
> > in index
> >  converting
> > 
> > The idx_to_offset() function returns type int (32-bit signed), but
> > MSR_PKG_ENERGY_STAT is greater than INT_MAX (or rather, would be
> > interpreted as a negative number). The end result is that it hits
> > the if (offset < 0) check in update_msr_sum() resulting in the timer
> > callback for updating the stat in the background when long durations
> > are used to not happen. The similar issue exists in offset_to_idx()
> > and update_msr_sum().
> > 
> > This patch fixes this issue by converting the 'int' type to 'off_t'
> > accordingly.
> 
> This patch covers all of the places I know about which had type issues
> - it should be good. Thanks!
> 
Okay, as per Boris' suggestion, this patch has changed the off_t to unsigned int,
and the print format is kept the same as '%x' without casting, how about this: