Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors

From: Borislav Petkov
Date: Fri Apr 23 2021 - 10:32:09 EST


On Fri, Apr 23, 2021 at 09:34:30PM +0800, Chen Yu wrote:
> I see, I'll add Calvin's SOB here. Previously I thought the 'From' field might
> be enough to indicate the Author, but it seems to not be the case.

The From: field is used by git to take the author but that's not the
problem. You need the author her/himself to sign off on the work - no
one else can do that.

You can refresh on that here:

Documentation/process/submitting-patches.rst

> Got it. The off_t was derived from old code in this file from get_msr() and alike,
> let me convert this return value to unsigned int.

See my reply to Calvin - it needs to by off_t after all.

Thx.

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg