Re: [PATCH 1/1] rtc: pcf85063: add integrity check

[Gervais, Francois]

>>> I'm not sure I get the use case because PCF85063_REG_CTRL2 should be
>>> initialized properly after the driver is probed anyway. The other two
>>> can be set from userspace once it detects the oscillator failure which
>>> would be better at deciding the policy anyway.
>> 
>> Thank you for the feedback I think I understand now.
>> 
>> We saw the reported problem on devices running kernel v5.4 which doesn't
>> have the common clock framework support and so PCF85063_REG_CTRL2
>> clkout was not initialized by the kernel and left at hardware default.
>> 
>> I guess with CCF support, if PCF85063_REG_CTRL2 gets corrupted on
>> power application, on driver probe the clkout value will be set to 0b000
>> or some known default.
>> 
>> I'm not familiar the CCF, do you know if it's the case that default values
>> will be set on boot?
>
> The CCF will disable any clocks that are not used on boot so the clock
> will be either used and configured or not used and disabled.

I see now, thank you for the feedback.

I changed the patch status to "Not Applicable" and archived it.