Re: [PATCH v25 21/30] mm: Re-introduce vm_flags to do_mmap()

From: Yu, Yu-cheng
Date: Fri Apr 23 2021 - 12:00:15 EST


On 4/23/2021 3:31 AM, Kirill A. Shutemov wrote:
On Thu, Apr 15, 2021 at 03:14:10PM -0700, Yu-cheng Yu wrote:
There was no more caller passing vm_flags to do_mmap(), and vm_flags was
removed from the function's input by:

commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()").

There is a new user now. Shadow stack allocation passes VM_SHADOW_STACK to
do_mmap(). Thus, re-introduce vm_flags to do_mmap().

Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
Reviewed-by: Peter Collingbourne <pcc@xxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: linux-mm@xxxxxxxxx

Reviewed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>


Thanks for reviewing.

Yu-cheng