Re: [PATCH v3 2/2] dt-bindings: gpio: Add devicetree binding for IDT 79RC32434 GPIO controller
From: Rob Herring
Date: Fri Apr 23 2021 - 13:54:01 EST
On Thu, Apr 22, 2021 at 05:20:54PM +0200, Thomas Bogendoerfer wrote:
> Add YAML devicetree binding for IDT 79RC32434 GPIO controller
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> ---
> Changes in v3:
> - renamed to idt,32434-gpio
> - drop ngpio description
> - use gpio0: gpio@50004 in example
>
> .../devicetree/bindings/gpio/idt,32434.yaml | 71 +++++++++++++++++++
Not quite: idt,32434-gpio.yaml
> 1 file changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/idt,32434.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/idt,32434.yaml b/Documentation/devicetree/bindings/gpio/idt,32434.yaml
> new file mode 100644
> index 000000000000..bdbbe01855e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/idt,32434.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/idt,32434.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT 79RC32434 GPIO controller
> +
> +maintainers:
> + - Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: idt,32434-gpio
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: gpio
> + - const: pic
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + ngpios:
> + minimum: 1
> + maximum: 32
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - gpio-controller
> + - "#gpio-cells"
> + - ngpios
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpio0: gpio@50004 {
> + compatible = "idt,32434-gpio";
> + reg = <0x50004 0x10>, <0x38030 0x0c>;
> + reg-names = "gpio", "pic";
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + interrupt-parent = <&cpuintc>;
> + interrupts = <6>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + ngpios = <14>;
> + };
> --
> 2.29.2
>