Re: [PATCH 1/4] misc: eeprom_93xx46: Add new at93c56 and at93c66 compatible strings
From: Jonathan Neuschäfer
Date: Sat Apr 24 2021 - 09:02:42 EST
On Sat, Apr 24, 2021 at 02:30:30PM +0200, Emmanuel Gil Peyrot wrote:
> These two devices have respectively 2048 and 4096 bits of storage,
> compared to 1024 for the 93c46.
>
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@xxxxxxxxxxxx>
> ---
> .../bindings/misc/eeprom-93xx46.txt | 3 +++
> drivers/misc/eeprom/eeprom_93xx46.c | 21 ++++++++++++++++++-
> include/linux/eeprom_93xx46.h | 3 +++
> 3 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index 7b636b7a8311..72ea0af368d4 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -2,7 +2,10 @@ EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
>
> Required properties:
> - compatible : shall be one of:
> + "atmel,at93c46"
> "atmel,at93c46d"
> + "atmel,at93c56"
> + "atmel,at93c66"
> "eeprom-93xx46"
> "microchip,93lc46b"
> - data-size : number of data bits per word (either 8 or 16)
The DT binding patch should ideally be separate from the driver patch.
> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
> index 80114f4c80ad..64dd76f66463 100644
> --- a/drivers/misc/eeprom/eeprom_93xx46.c
> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
other than that, the patch looks fine to me, AFAICT.
Thanks,
Jonathan
Attachment:
signature.asc
Description: PGP signature