Re: [PATCH] leds: LEDS_BLINK_LGM should depend on X86

From: Geert Uytterhoeven
Date: Mon Apr 26 2021 - 03:06:52 EST


Hi Pavel,

On Sun, Apr 25, 2021 at 10:57 PM Pavel Machek <pavel@xxxxxx> wrote:
> > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO)
> > is only present on Intel Lightning Mountain SoCs. Hence add a
> > dependency on X86, to prevent asking the user about this driver when
> > configuring a kernel without Intel Lightning Mountain platform support.
> >
> > While at it, merge the other dependencies into a single statement.
> >
> > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> This rejected, so I applied it by hand.

Thank you!

> I'm deleting the Fixes tag --
> we don't want this in stable.

Why not? Shouldn't people running stable be shielded from useless
questions while configuring their kernels?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds