[PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value

From: Sherry Sun
Date: Mon Apr 26 2021 - 03:57:35 EST


This issue is reported by Coverity Check.
In lpuart_probe, return value of function which returns null is
dereferenced without checking.

Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx>
---
drivers/tty/serial/fsl_lpuart.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 777d54b593f8..c95e71fd2ca0 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2589,6 +2589,9 @@ static int lpuart_probe(struct platform_device *pdev)
struct resource *res;
int ret;

+ if (!sdata)
+ return -ENODEV;
+
sport = devm_kzalloc(&pdev->dev, sizeof(*sport), GFP_KERNEL);
if (!sport)
return -ENOMEM;
--
2.17.1