Re: [PATCH net-next v6 08/10] net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support

From: Andrew Lunn
Date: Mon Apr 26 2021 - 08:39:12 EST


> > > +static const struct of_device_id ksz8863_dt_ids[] = {
> > > + { .compatible = "microchip,ksz8863" },
> > > + { .compatible = "microchip,ksz8873" },
> > > + { },
> > > +};
> >
> > Is there code somewhere which verifies that what has been found really
> > does match what is in device tree? We don't want errors in the device
> > tree to be ignored.
> >
> > Andrew
>
> Hm, it makes sense. But it is not regression of this patches, is it OK
> to mainline it separately?

Yes, but please don't forget it. Without verification, DT writers will
get it wrong. And then it becomes useless because you have to assume
it is wrong. Otherwise you break backwards compatibility.

Andrew