Re: [PATCH] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns()

From: Peter Zijlstra
Date: Mon Apr 26 2021 - 08:40:28 EST


On Mon, Apr 26, 2021 at 02:33:00PM +0200, Thomas Gleixner wrote:

> >> + force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases);
> >> + force_local &= base->cpu_base->next_timer == timer;
> >
> > Using bitwise ops on a bool is cute and all, but isn't that more
> > readable when written like:
> >
> > force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases) &&
> > base->cpu_base->next_timer == timer;
> >
>
> Which results in an extra conditional branch.

Srlsy, compiler not smart enough?