Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change
From: Joe Perches
Date: Mon Apr 26 2021 - 22:43:40 EST
On Mon, 2021-04-26 at 08:11 -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 23, 2021 at 8:13 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> >
> > On Fri, 2021-04-23 at 12:35 +0530, Rajendra Nayak wrote:
> > > Fix a missed newline, and update a comment which is stale
> > > after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
> > > blowing on sc7280'
> > > No other functional change in this patch.
> > []
> > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> > []
> > > @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
> > > }
> > >
> > > /*
> > > - * Hardware requires 1.8V min for fuse blowing; this may be
> > > + * Hardware requires a min voltage for fuse blowing; this may be
> > > * a rail shared do don't specify a max--regulator constraints
> >
> > so don't?
> >
> > > * will handle.
> > > */
> >
> > but the comment doesn't make much overall sense to me.
>
> What part of it doesn't make sense, exactly?
max--regulator
I think that should be something like:
Hardware requires a minimum voltage for fuse blowing.
This may be a shared rail so don't specify a maximum.
Regulator constraints will handle (what exactly, it?)